SK-3068: Fix README API examples in both SDK READMEs - #197
Merged
Conversation
- Skyflow.ElementType -> SkyflowElementType (actual enum name) - ElementMatchRule -> ElementValueMatchRule (actual class name) - add missing context arg to container.create() examples Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
yaswanth-pula-skyflow
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pre-existing API-example errors in both SDK READMEs. Doc-only — no SDK/source changes, so skyvault stays byte-identical to 1.27.0.
Changes (both
flowvault/README.mdandskyvault/README.md)Skyflow.ElementType→SkyflowElementType— the actual enum name (the old form never compiled); the SDK has usedSkyflowElementTypesince 1.27.0.ElementMatchRule→ElementValueMatchRule— the actual class name in the custom-validation example.contextargument tocontainer.create()examples that omitted it.The element-creation and custom-validation snippets now compile against the shipped API. The samples were already correct — only the READMEs were out of date.
🤖 Generated with Claude Code